Merged
Conversation
| data class Item( | ||
| val status: ProDetailsStatus, | ||
| @SerialName("plan") | ||
| val planDuration: ServerPlanDuration, |
Collaborator
There was a problem hiding this comment.
So this is a mandatory property? Once added there's no going back...
Collaborator
Author
There was a problem hiding this comment.
I'll check with the team, though I'm not sure what it would mean for it to be missing
| val validUntil: Instant | ||
| val duration: ProSubscriptionDuration | ||
| val subscriptionDetails: SubscriptionDetails | ||
| val subscriptionDetails: PaymentProviderMetadata |
Collaborator
There was a problem hiding this comment.
Should this be renamed?
SessionHero01
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wiring the server data to our presentation models.
Removed the SubscriptionDetails in favour of the server data directly.
Also removed some code from the subscriber in favour of the payment metadata.
A successful google subscription purchase now links up to our server endpoint.
Cleaned up compose previews.